Hi Jon, Thank you very much for reviewing so many packages in a short time.
On Tue, 19 Sep 2023 03:53:14 +0900 Takashi Yano wrote: > On Mon, 18 Sep 2023 17:49:45 +0100 > Jon Turney wrote: > > On 17/09/2023 14:14, Takashi Yano via Cygwin-apps wrote: > > > I'd like adopt the fluidsynth package. > > > Thanks in advance. > > > > Thanks. > > > > I added this to your packages. > > > > > > > > fluidsynth.cygport > > > > > > inherit cmake > > > > > > NAME="fluidsynth" > > > VERSION=2.3.2 > > > RELEASE=1 > > > LICENSE="LGPL-2.1-or-later" > > > CATEGORY="Audio" > > > SUMMARY="SoundFont software synthesizer" > > > DESCRIPTION="FluidSynth is a real-time software synthesizer based on the > > > SoundFont 2 specifications." > > > HOMEPAGE="http://www.fluidsynth.org/"; > > > SRC_URI="https://github.com/FluidSynth/fluidsynth/archive/v${VERSION}/fluidsynth-${VERSION}.tar.gz"; > > > > > > PKG_NAMES="${NAME} lib${NAME}3 lib${NAME}-devel" > > > fluidsynth_CONTENTS="usr/bin/*.exe usr/share/" > > > libfluidsynth3_CATEGORY="Libs" > > > libfluidsynth3_SUMMARY="${SUMMARY} library" > > > libfluidsynth3_CONTENTS="usr/bin/cygfluidsynth-3.dll" > > > libfluidsynth_devel_CATEGORY="Libs" > > > libfluidsynth_devel_SUMMARY="${SUMMARY} library" > > > libfluidsynth_devel_CONTENTS=" > > > usr/include/fluidsynth* > > > usr/lib/libfluidsynth.dll.a > > > usr/lib/pkgconfig/fluidsynth.pc > > > " > > > > > > PKG_IGNORE="usr/lib/cmake/fluidsynth/*.cmake" > > > > It would be normal to include these files in the libfluidsynth_devel > > package, for use by cmake's find_package command. > > Yeah, I have includes them in devel package. > > > Is there some reason to exclude them? If so, a comment explaining why > > would be a good idea. > > > > > # dbus: only for RealtimeKit > > > # portaudio: playback is just static > > > > Maybe the last line in this comment is no longer accurate? > > I confirmed that fluidsynth works properly with latest portaudio package. > So, I enabled the support for portaudio. I forgot to delete this line. > Thanks. > > I have revised the project files. Could you please recheck them? Can I go ahead as for fluidsynth as well? -- Takashi Yano <takashi.y...@nifty.ne.jp>
