https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=44693e80b1dd6f97a674ddd383521a21c09c6dad
commit 44693e80b1dd6f97a674ddd383521a21c09c6dad Author: Ken Brown <[email protected]> Date: Fri Sep 3 09:42:00 2021 -0400 Cygwin: pipes: minor code cleanup Clarify a comment in raw_read, and remove a useless line from raw_write. Diff: --- winsup/cygwin/fhandler_pipe.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc index 85730d039..81b1aed5e 100644 --- a/winsup/cygwin/fhandler_pipe.cc +++ b/winsup/cygwin/fhandler_pipe.cc @@ -248,8 +248,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len) WaitForSingleObject (read_mtx, INFINITE); - /* Make sure never to request more bytes than half the pipe - buffer size. Every pending read lowers WriteQuotaAvailable + /* If the pipe is empty, don't request more bytes than half the + pipe buffer size. Every pending read lowers WriteQuotaAvailable on the write side and thus affects select's ability to return more or less reliable info whether a write succeeds or not. @@ -425,7 +425,6 @@ fhandler_pipe::raw_write (const void *ptr, size_t len) set_errno (EBADF); else __seterrno (); - len = (size_t) -1; } else if (NT_SUCCESS (status)) {
