https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3e80b12fde6126d85ae2ee58ba57e499c57b6c92

commit 3e80b12fde6126d85ae2ee58ba57e499c57b6c92
Author: Takashi Yano <[email protected]>
Date:   Tue Sep 14 12:48:03 2021 +0900

    Cygwin: fhandler_base::dup Reflect O_CLOEXEC to inheritance flag.
    
    - Currently fhandler_base::dup duplicates handles with bInheritHandle
      TRUE unconditionally. This patch reflects O_CLOEXEC flag to that
      parameter.

Diff:
---
 winsup/cygwin/fhandler.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
index 39fe2640a..9dfe70be3 100644
--- a/winsup/cygwin/fhandler.cc
+++ b/winsup/cygwin/fhandler.cc
@@ -1308,7 +1308,7 @@ fhandler_base::init (HANDLE f, DWORD a, mode_t bin)
 }
 
 int
-fhandler_base::dup (fhandler_base *child, int)
+fhandler_base::dup (fhandler_base *child, int flags)
 {
   debug_printf ("in fhandler_base dup");
 
@@ -1317,7 +1317,7 @@ fhandler_base::dup (fhandler_base *child, int)
     {
       if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
                            GetCurrentProcess (), &nh,
-                           0, TRUE, DUPLICATE_SAME_ACCESS))
+                           0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
        {
          debug_printf ("dup(%s) failed, handle %p, %E",
                        get_name (), get_handle ());

Reply via email to