https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=26775886a3b4d3c858f40f6f42b61f866d9c1c2a
commit 26775886a3b4d3c858f40f6f42b61f866d9c1c2a Author: Corinna Vinschen <[email protected]> AuthorDate: Wed Jul 12 13:31:31 2023 +0200 Commit: Corinna Vinschen <[email protected]> CommitDate: Wed Jul 26 15:19:59 2023 +0200 Cygwin: gen_full_path_at: drop never reached code The check if the local variable p is NULL is useless. The preceeding code always sets p to a valid pointer, or it crashes if path_ret is invalid (which would be a bug in Cygwin). Fixes: c57b57e5c43a ("* cygwin.din: Sort.") Reviewed-by: Johannes Schindelin <[email protected]> Signed-off-by: Corinna Vinschen <[email protected]> Diff: --- winsup/cygwin/syscalls.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 5adc614ec30f..a8b8206af0fc 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -4447,11 +4447,6 @@ gen_full_path_at (char *path_ret, int dirfd, const char *pathname, } p = stpcpy (path_ret, cfd->get_name ()); } - if (!p) - { - set_errno (ENOTDIR); - return -1; - } if (pathname) { if (!*pathname)
