----- Original Message ----- From: "Robert Collins" <[EMAIL PROTECTED]> To: "Michael A Chase" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Monday, January 28, 2002 20:55 Subject: Re: [PATCH]Reduce messages in setup.log
> I think you've missed the point of the messages. They indicate > incomplete functions, so that the main log shows what the *program* > should have detected. > > compress_gz::error returns an internal state error value. > compress_bz::error returns 0! > > Likewise for everything that logs to setup.log - it should stay there IF > and only IF it's not properly implemented. > > I will happily accept patches addressing the core issues, but not to > hide them :}. > > I thought when you initially described this that there where a bunch of > messages that *shouldn't* be going to the log, but until I review the > body of your patches, I can't meaningfully confirm on a per function > basis. I didn't say they shouldn't go to a log, but I didn't think they were useful in setup.log. If the intention of those messages is to highlight methods that should have been overridden but aren't, then setup.log is the right place. -- Mac :}) ** I normally forward private questions to the appropriate mail list. ** Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.htm Give a hobbit a fish and he eats fish for a day. Give a hobbit a ring and he eats fish for an age.
