lsa handle in security.cc

[Pierre A. Humblet]

The invalid value for an lsa handle in security.cc
is inconsistent. It is initially NULL, but in 
close_local_policy () it is INVALID_HANDLE_VALUE.
Calling LsaClose(NULL) causes a fault, at least in gdb.

The patch uses INVALID_HANDLE_VALUE uniformly, instead of 
NULL. The converse would probably work as well, not sure
which is better.

Pierre

2002-05-19  Pierre Humblet <[EMAIL PROTECTED]>

        * security.cc (open_local_policy): Initialize lsa to    INVALID_HANDLE_VALUE
instead of NULL.
        (get_logon_server_and_user_domain): Test for
        INVALID_HANDLE_VALUE instead of NULL.
        (create_token): Both of the above. 


--- security.cc.orig    2002-05-17 05:32:46.000000000 -0400
+++ security.cc 2002-05-19 12:07:10.000000000 -0400
@@ -180,7 +180,7 @@
 open_local_policy ()
 {
   LSA_OBJECT_ATTRIBUTES oa = { 0, 0, 0, 0, 0, 0 };
-  LSA_HANDLE lsa = NULL;
+  LSA_HANDLE lsa = INVALID_HANDLE_VALUE;
 
   NTSTATUS ret = LsaOpenPolicy(NULL, &oa, POLICY_EXECUTE, &lsa);
   if (ret != STATUS_SUCCESS)
@@ -258,7 +258,7 @@
 {
   BOOL ret = FALSE;
   LSA_HANDLE lsa = open_local_policy ();
-  if (lsa)
+  if (lsa != INVALID_HANDLE_VALUE)
     {
       ret = get_lsa_srv_inf (lsa, logonserver, userdomain);
       close_local_policy (lsa);
@@ -723,7 +723,7 @@
 create_token (cygsid &usersid, cygsid &pgrpsid)
 {
   NTSTATUS ret;
-  LSA_HANDLE lsa = NULL;
+  LSA_HANDLE lsa = INVALID_HANDLE_VALUE;
   char logonserver[INTERNET_MAX_HOST_NAME_LENGTH + 1];
   int old_priv_state;
 
@@ -764,7 +764,7 @@
     goto out;
 
   /* Open policy object. */
-  if (!(lsa = open_local_policy ()))
+  if ((lsa = open_local_policy ()) == INVALID_HANDLE_VALUE)
     goto out;
 
   /* Get logon server. */