On Sat, 2002-11-23 at 01:55, Thomas Pfaff wrote: > > > On Tue, 5 Nov 2002, Robert Collins wrote: > > > Overall this looks good. What happens to non-cygwinapi created threads > > now though? You mention you don't agree with the code, but I can't see > > (from a brief look) how you correct it. > > > > BTW: I'm currently packing to move house, so don't expect much feedback > > until late next week, or early the week after :[. > > > > Ping
Pong. I've added the test cases to the test suite. In future please
follow the guidelines in testsuite/readme for test behaviour - running
$ ./testname || echo foo
should echo foo on failures - and neither of your test cases did that
initially.
Also, the initMainThread behaviour:
initMainThread (bool dosomething)
{
if (!dosomething)
return;
...
I don't like. I'd rather we not call initMainThread than call it with a
boolean as above.
If dosomething was internal to the pthread class, so that initMainThread
became:
initMainThread()
{
if (!dosomething)
return;
...
I'd have no issue.
Anyway, thanks again for excellent work, and the patch has been
committed.
Rob
--
---
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
---
signature.asc
Description: This is a digitally signed message part
