Re: dtable.cc (build_fh_pc): serial port handling

[Brian Ford]

Revised patch attached.  I noticed that there was a redundant
cygdrive case too, so I removed it.

2003-11-12  Brian Ford  <[EMAIL PROTECTED]>

        * dtable.cc (build_fh_pc): Use DEV_SERIAL_MAJOR to catch all
        serial ports.  Remove redundant FH_CYGDRIVE case since it is
        handled by DEV_CYGDRIVE_MAJOR.

Chris,

Do you have a cleanup here planned?  Should I just ignore this stuff for
a while?

FYI, this is the reason I am here:

http://www.cygwin.com/ml/cygwin/2003-10/msg01750.html

He offered to test my tcflush patch, but reported being unable to
open /dev/ttyS0 with the cvs compiled Cygwin.

On Wed, 12 Nov 2003, Corinna Vinschen wrote:

> On Tue, Nov 11, 2003 at 06:25:41PM -0600, Brian Ford wrote:
> > Here is one I think I do understand.
> >
> > 2003-11-11  Brian Ford  <[EMAIL PROTECTED]>
> >
> >     * dtable.cc (build_fh_pc): Use DEV_SERIAL_MAJOR to catch all
> >     serial ports.
> >
>
> This looks right to me.  Chris?
>
> Corinna
>

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444
Index: dtable.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/dtable.cc,v
retrieving revision 1.119
diff -u -p -r1.119 dtable.cc
--- dtable.cc   1 Oct 2003 12:36:39 -0000       1.119
+++ dtable.cc   12 Nov 2003 19:06:52 -0000
@@ -339,6 +339,9 @@ build_fh_pc (path_conv& pc)
       case DEV_TAPE_MAJOR:
        fh = cnew (fhandler_dev_tape) ();
        break;
+      case DEV_SERIAL_MAJOR:
+       fh = cnew (fhandler_serial) ();
+       break;
       default:
        switch (pc.dev)
          {
@@ -347,17 +350,11 @@ build_fh_pc (path_conv& pc)
          case FH_CONOUT:
            fh = cnew (fhandler_console) ();
            break;
-         case FH_CYGDRIVE:
-           fh = cnew (fhandler_cygdrive) ();
-           break;
          case FH_PTYM:
            fh = cnew (fhandler_pty_master) ();
            break;
          case FH_WINDOWS:
            fh = cnew (fhandler_windows) ();
-           break;
-         case FH_SERIAL:
-           fh = cnew (fhandler_serial) ();
            break;
          case FH_FIFO:
            fh = cnew (fhandler_fifo) ();