On Fri, Jan 23, 2004 at 10:59:52AM +0100, Corinna Vinschen wrote: >On Jan 22 18:33, Pierre A. Humblet wrote: >> 2004-01-22 Pierre Humblet <[EMAIL PROTECTED]> >> >> * fhandler_socket.cc (fhandler_socket::create_secret_event): Avoid >> creating multiple handles. Always allow event inheritance but set the >> handle inheritance appropriately. Improve error handling. >> (fhandler_socket::check_peer_secret_event): Improve error handling. >> (fhandler_socket::close_secret_event): Simply call CloseHandle. >> (fhandler_socket::set_close_on_exec): Set secret event inheritance. > >Looks good. Please check it in.
I agree, with one nit. Was there a reason for getting rid of the handle protection in this patch? We are apparently stumbling over a problem with handle corruption in the current CVS so removing a chance for protection seems like we're going backwards. cgf
