On Apr 10 13:03, Corinna Vinschen wrote: > On Apr 9 23:19, Pierre A. Humblet wrote: > > Looking to the future, now that fs_info::update isn't really doing an > > update (a better name would be fs_info::get), it turns out that the > > char name_storage[CYG_MAX_PATH]; > > char root_dir_storage[CYG_MAX_PATH]; > > fields in fs_info can be removed (that requires a few other minor changes). > > Doing that would cut down the size of a fhandler from about 920 bytes > > to 400, which looks like a good thing. > > Yes, you're right. I'm going to work on this.
I've removed name_storage and root_dir_storage from fs_info. The only downside of this should be that statfs now has to call rootdir() by itself. All fs flags are now centralized in fs_info. That seems to allow another slight speed inprovement, even though that's just a few per cent. > > I am somewhat concerned that the update of fsinfo isn't thread safe. > > I don't know how the overhead of making it thread safe compares with > > the overhead of the old method (not caching the fs_info). > > I'll change that soon. The handling of the global fsinfo array should be thread safe now. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer mailto:[EMAIL PROTECTED] Red Hat, Inc.
