On Sat, May 08, 2004 at 02:12:16PM -0400, Pierre A. Humblet wrote: >On Fri, 7 May 2004 22:55:29 -0400, Christopher Faylor wrote: >>The memory leak is a good point (and has mildly bothered me since >>implemented this) but aren't you essentially opening a mechanism to >>access things outside of the chrooted environment with this patch? > >I don't think so. spawn uses path_conv::check, which will bomb if the >program is outside the chroot area, no matter the Windows PATH. One >has to be careful not to put any Windows program in that area, as it >won't honor the changeroot. DLLs may open files outside of the chroot >area, but that's independent of the DLLs locations.
Ok. >> I wonder if, these days, all of the environment cache should be in >> the cygheap. > >That would be reasonable, and would avoid quite a few translations. >Things can perhaps be reworked a little to remove the posix member from the >win_env, as it should always be equal to the value in the Cygwin environment. >Also the native member is updated every time its mate changes in the Cygwin >environment, so it can be blindly copied to the Windows environment >by build_env (no need to check if its has changed). Unless the user manipulates the environment directly, which a few programs do. But, maybe that's already a problem with the current scheme. It's been a while since I've tried to wrap my head around this. We're still suffering from some bad design decisions made early on in cygwin development. cgf
