Christopher Faylor wrote:
I hate to say this but I really don't like doing things this way. If we need to use wide character support then it should just be a wholesale replacement, not a bunch of wrappers around existing functions. Corinna and I have talked about using the FooW functions for a long time. There are some fundamental changes required to incorporate these into cygwin but I don't think that wrappers around everything are the way to go. cgf
I hope you will understand that both approaches (wapper approach and non-wrapper approach) are _compatible_. In Cygwin-1.5.20-1 on Windows XP, fhandler_disk_file::readdir() at winsup/cygwin/fhandler_disk_file.cc does not use FindNextFileA, one of ANSI WIN32 APIs, anymore. It use so-called undocumented APIs which are Unicode-base. You have implemented your approach here a little, haven't you? And the UTF-8 Cygwin still works very well ;-) Wrapper functions do _nothing_ where wide characters are used. It is sys_wcstombs that converts Unicode to UTF-8 here. The cygwin programs can enjoy UTF-8 _now_ with the UTF-8 patch, and someday in the future when UTF-8 is supported natively, you can delete wrapper functions which are not used anymore then. -- SUZUKI Hisao
