On Sat, Jun 16, 2007 at 09:47:41PM +0200, Corinna Vinschen wrote: >On Jun 16 08:38, Brian Dessent wrote: >> This is just due to __FBSDID not getting #defined to blank properly. >> The file includes sys/cdefs.h and newlib's copy contains the required >> bit (#define __FBSDID(x) /* nothing */) however when building with >> Cygwin, the Cygwin headers are used and Cygwin's sys/cdefs.h doesn't >> contain this. The appropriate fix is either to modify strcasestr.c or >> to fix Cygwin's sys/cdefs.h. I think the latter is probably the better >> choice, since it seems that there is precedent already in newlib for >> being able to just #include <sys/cdefs.h> followed by use of __FBSDID >> without having to explicitly undefine it. Patch attached which fixes >> the build for me. > >Thanks for the patch. However, when comparing newlib's and Cygwin's >sys/cdefs.h file, I'm wondering why Cygwin needs its own version of >sys/cdefs.h at all. > >Chris, do you know why we maintain our own sys.cdefs.h? It looks >like we could just delete it.
Cygwin's cdefs.h predates the newlib version. I've removed Cygwin's version. cgf
