On Jul 19 12:03, Eric Blake wrote: > On 07/19/2010 10:45 AM, Corinna Vinschen wrote: > >> Okay to commit, along with a corresponding patch to doc/new-features.sgml > >> and a cygwin-specific patch to newlib's stdlib.h? > > > > Yep. Thanks for the patch. I CCed the newlib list. The change to > > newlib's stdlib.h is preapproved (#ifndef __STRICT_ANSI__ just like > > mkstemp et al). > > For the record, here's the (pre-approved) patches for newlib and cygwin > documentation that I'm pushing in tandem with the original cygwin patch. > It also fixes a couple of minor problems I noticed while in the area - > cygwin's cat has been binary-only for some time now, and newlib's > stdlib.h was not robust to a user file that used #define warning prior > to including the system header. > > > > > Btw., would you mind to enhance newlib's libc/stdio/mktemp.c in the same > > manner (_ELIX_LEVEL >= 4)? > > The mkostemp[s] additions are guarded by the same levels as mkstemps, > since all three interfaces are equally non-portable.
Thanks very much for the patch. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat
