On Thu, Feb 10, 2011 at 10:50:54AM +0100, Corinna Vinschen wrote: >On Feb 9 21:15, Christopher Faylor wrote: >> On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >> >+/* Newlib's <string.h> provides declarations for two strerror_r >> >+ variants, according to preprocessor feature macros. It does the >> >+ right thing for GNU strerror_r, but its __xpg_strerror_r mishandles >> >+ a case of EINVAL when coupled with our strerror() override.*/ >> > #if 0 >> >> Can't we get rid of this now? > >I agree. We should simply implement strerror_r by ourselves, even if >it's identical to newlib's strerror_r. In the long run it's less >puzzeling to have all the strerror variants in one place.
Whichever we do, we surely don't need an #if 0/#endif in the code. cgf
