On Tue, 2011-05-17 at 23:35 -0400, Charles Wilson wrote: > On 5/17/2011 8:20 PM, Yaakov (Cygwin/X) wrote: > > This patch series adds error.h and the error(3) functions, a GNU > > extension: > > > > http://www.kernel.org/doc/man-pages/online/pages/man3/error.3.html > > > Shouldn't the definitions in error.h be guarded by #ifdef GNU_SOURCE or > something
If this were required, it would have been indicated in the aforementioned documentation. My extensive[1] testing of these functions on Linux also showed that this was not required. (The _GNU_SOURCE in the test app is only required to pull in program_invocation_name, a GNU extension declared in <errno.h>.) > or are we relying on error.h itself, as a non-standard > header, "hiding" the symbols implicitly? E.g. if you don't want the > functions, don't include <error.h>? Exactly, just as on Linux. Yaakov [1] Just how extensive, you ask? See http://sourceware.org/bugzilla/show_bug.cgi?id=12766
