On Fri, Aug 19, 2011 at 01:52:53PM +0200, Corinna Vinschen wrote: >On Aug 18 20:54, Yaakov (Cygwin/X) wrote: >> On Thu, 2011-08-18 at 21:55 +0200, Corinna Vinschen wrote: >> > > 2011-08-18 Yaakov Selkowitz <yselkowitz@...> >> > > >> > > * devices.h (fh_devices): Define DEV_MISC_MAJOR, DEV_MEM_MAJOR, >> > > DEV_SOUND_MAJOR. Use throughout. >> > > * fhandler_proc.cc (proc_tab): Add /proc/devices and /proc/misc >> > > virtual files. >> > > (format_proc_devices): New function. >> > > (format_proc_misc): New function. >> > >> > I think the patch is basically ok, but it's missing the "cons" entry >> > for consoles, equivalent to the "tty" entry. >> >> Revised patch attached. OK to commit? >> >> >> Yaakov >> > >> 2011-08-18 Yaakov Selkowitz <yselkowitz@...> >> >> * devices.h (fh_devices): Define DEV_MISC_MAJOR, DEV_MEM_MAJOR, >> DEV_SOUND_MAJOR. Use throughout. >> * fhandler_proc.cc (proc_tab): Add /proc/devices and /proc/misc >> virtual files. >> (format_proc_devices): New function. >> (format_proc_misc): New function. > >Yes, I think that's ok.
Isn't it somehow possible to just iterate over dev_storage and generate this automatically rather than hard-coding the names of devices? cgf
