On Jul 6 14:41, Yaakov Selkowitz wrote: > --- > winsup/cygwin/path.cc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc > index 446d746..5eb076f 100644 > --- a/winsup/cygwin/path.cc > +++ b/winsup/cygwin/path.cc > @@ -48,7 +48,7 @@ > c: means c:\. > */ > > -#define _BASENAME_DEFINED > +#define basename basename
As part of the sources, this define needs an informative comment, describing why it's necessary. Ideally not in just three words following on the same line but in full english preceeding the #define line. With such a comment and a ChangeLog entry, patch is ok. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
pgp8Ua8lDq9vP.pgp
Description: PGP signature
