On Jan 18 23:58, Yaakov Selkowitz wrote: > This adds FreeBSD-derived implementations to replace the glibc-derived > standalone implementation shipped in the catgets package. An integrated > implementation avoids the need to remember to install libcatgets-devel and > modify the build to link with -lcatgets. > > The easiest way to test this is: > > 1) Uninstall catgets and libcatgets-devel. > 2) Install Cygwin rebuilt with this patch, particularly the DLL, nl_types.h, > libcygwin.a, and gencat.exe > 3) Rebuild tcsh. The following should be seen during configure: > > checking for gencat... /usr/bin/gencat > [snip] > checking for library containing catgets... none required > > And the resulting binary should show catclose/catgets/catopen imports from > cygwin1.dll, not cyggetcats1.dll. > 4) Install this tcsh, then run an invalid command, e.g.: > > $ LANG=fr_FR tcsh -c '()' > Commande nulle incorrecte. > > Yaakov Selkowitz (3): > Guard langinfo.h nl_item from multiple typedefs > cygwin: add catopen, catgets, catclose > cygwin: add gencat tool > > newlib/libc/include/langinfo.h | 3 + > winsup/cygwin/Makefile.in | 1 + > winsup/cygwin/common.din | 3 + > winsup/cygwin/include/cygwin/version.h | 3 +- > winsup/cygwin/include/nl_types.h | 100 +++++ > winsup/cygwin/libc/msgcat.c | 478 ++++++++++++++++++++++ > winsup/utils/Makefile.in | 2 +- > winsup/utils/gencat.c | 696 > +++++++++++++++++++++++++++++++++ > 8 files changed, 1284 insertions(+), 2 deletions(-) > create mode 100644 winsup/cygwin/include/nl_types.h > create mode 100644 winsup/cygwin/libc/msgcat.c > create mode 100644 winsup/utils/gencat.c > > -- > 2.15.1
Patch is fine, but I'd prefer if the whitespace problems are fixed first, even if they are from upstream: Applying: Guard langinfo.h nl_item from multiple typedefs Applying: cygwin: add catopen, catgets, catclose .git/rebase-apply/patch:268: space before tab in indent. np->name = strdup(n); \ .git/rebase-apply/patch:275: space before tab in indent. SLIST_INSERT_HEAD(&cache, np, list); \ warning: 2 lines add whitespace errors. Applying: cygwin: add gencat tool .git/rebase-apply/patch:52: trailing whitespace. * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS .git/rebase-apply/patch:337: trailing whitespace. } warning: 2 lines add whitespace errors. Applying: cygwin: update docs for 2.10.0 .git/rebase-apply/patch:21: trailing whitespace. - Built-in implementation of _FORTIFY_SOURCE guards for functions in .git/rebase-apply/patch:74: trailing whitespace. Built-in implementation of _FORTIFY_SOURCE guards for functions in warning: 2 lines add whitespace errors. Are you going to provide a catgets deprecation package? Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
signature.asc
Description: PGP signature