On Jun 19 12:15, Brian Inglis wrote: > In test for for AMD/Intel Control flow Enforcement Technology user mode > shadow stack support replace Windows version tests with test of wincap > member addition has_user_shstk with Windows version dependent value > > Fixes: 41fdb869f998 fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 > cpuinfo > Signed-off-by: Brian Inglis <brian.ing...@shaw.ca> > > Brian Inglis (3): > wincap.h: add wincap member has_user_shstk > wincap.cc: set wincap member has_user_shstk true for 2004+ > fhandler/proc.cc: use wincap.has_user_shstk > > winsup/cygwin/fhandler/proc.cc | 8 ++++---- > winsup/cygwin/local_includes/wincap.h | 2 ++ > winsup/cygwin/wincap.cc | 10 ++++++++++ > 3 files changed, 16 insertions(+), 4 deletions(-)
Never mind, I fixed the remaining problems. Thanks for the patch, I pushed it with slight modifications to the commit messages. I'm a bit puzzled if my original mail https://cygwin.com/pipermail/cygwin-patches/2023q2/012280.html was really that unclear. Reiterating for the records: - Commit messages should really try to explain why the patch is made and what it's good for. In case of fixing a bug, the bug should be explained and, ideally, explain why the patch is the better solution. - If a patch fixes an older bug, it should say so and point out the commit which introduced the bug using the Fixes: tag. The format is Fixes: <12-digit-SHA1> ("<commit headline>") The parens and quoting chars are part of the format. - Every patch should contain a Signed-off-by: to indicate that you did the patch by yourself. That's easily automated by using `git commit -s'. - Other Tags like "Reported-by:" or "Tested-by:" are nice to have, but not essential. Thanks, Corinna
