On Mar 6 03:42, Takashi Yano wrote: > On Tue, 5 Mar 2024 17:54:19 +0100 > Corinna Vinschen wrote: > > On Mar 5 23:47, Takashi Yano wrote: > > > On Tue, 5 Mar 2024 11:14:46 +0100 > > > Corinna Vinschen wrote: > > > > This doesn't affect your patch, but while looking into this, what > > > > strikes me as weird is that fhandler_pipe::temporary_query_hdl() calls > > > > NtQueryObject() and assembles the pipe name via swscanf() every time it > > > > is called. > > > > > > > > Wouldn't it make sense to store the name in the fhandler's > > > > path_conv::wide_path/uni_path at creation time instead? > > > > The wide_path member is not used at all in pipes, ostensibly. > > > > > > Is the patch attached as you intended? > > > > Yes, but it looks like it misses a few potential simplifications: > > [...] > Thanks for advice. I have revised the patch.
Looks good, thanks! Corinna
