On Jul 25 00:26, Takashi Yano wrote: > On Thu, 24 Jul 2025 15:20:19 +0200 > Corinna Vinschen wrote: > > On Jul 24 15:13, Corinna Vinschen wrote: > > > On Jul 24 15:06, Corinna Vinschen wrote: > > > > On Jul 24 20:57, Takashi Yano wrote: > > > > > Previously, process_fd failed to correctly handle fhandlers using an > > > > > archetype. This was due to the missing PATH_OPEN flag in path_conv, > > > > > which caused build_fh_pc() to skip archetype initialization. The > > > > > root cause was a bug where open() did not set the PATH_OPEN flag > > > > > for fhandlers using an archetype. > > > > > > > > > > This patch introduces a new method, path_conv::set_isopen(), to > > > > > explicitly set the PATH_OPEN flag in path_flags in fhandler_base:: > > > > > open_with_arch(). > > > > Wouldn't this patch fix the problem as well? > > > > [...] > > > No, it wouldn't. flags are not or'ed in the followup code. Sigh. > > > [...] > > And no, this one wouldn't either. I'm not thinking straight ATM, sorry. > > Thanks. The following patch also fixes the issue, however, the intent of > the code is more unclear than v2 patch, I think. > The root cause is the same for pty and console, but fixes are different.
Yeah, v2 is it. Thanks, Corinna
