On Aug 2 11:18, Jeremy Drake via Cygwin-patches wrote:
> This prevents memory corruption if a newer app or dll is used with an
> older cygwin dll. This is an unsupported scenario, but it's still a
> good idea to avoid corrupting memory if possible.
>
> Fixes: 7d5c55faa1 ("Cygwin: add wrappers for newer new/delete overloads")
> Co-authored-by: Corinna Vinschen <cori...@vinschen.de>
> Signed-off-by: Jeremy Drake <cyg...@jdrake.com>
> ---
> winsup/cygwin/globals.cc | 4 +--
> winsup/cygwin/include/cygwin/version.h | 3 ++
> winsup/cygwin/lib/_cygwin_crt0_common.cc | 38 +++++++++++++-----------
> 3 files changed, 26 insertions(+), 19 deletions(-)
LGTM, please push.
Now for the question if we should keep this with 3.7, or if it makes
sense to backport to the 3.6 branch.
I'm not sure.
Theoretically this change doesn't change anything as long as libstdc++
and gcc didn't catch up. So it's no functional change for existing
apps, but it would prepare newly build apps to the new compiler and
libstdc++ lib builds.
OTOH, as long as it's only in the non-released build, we have still time
to fix things. The fixes necessary due to introducing this right with a
bug in 1.7.0-49 were not much fun. It would be great if we already had
a gcc/libstdc++ build to test against before a release...
What do you think?
Thanks,
Corinna
