On Feb 12 16:26, Igor Podgainoi wrote: > Currently Cygwin does not support the High Entropy Virtual Addressing > feature, also known as IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VA and > 64-bit Address Space Layout Randomization in Windows. > > Whereas on systems running on the x86_64 architecture this feature is > already disabled by default in the toolchain during the build process, > the AArch64 version of the toolchain leaves it enabled, even though it > is not mandatory to use it on Windows on Arm. Only the normal ASLR flag > IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE is mandatory, which this patch > does not address. > > Therefore, this patch manually introduces the addition of High Entropy > VA disabling flags into several places in various Makefile.am files. > This should prevent memory overlap bugs on AArch64. > > Tests fixed on AArch64: > winsup.api/ltp/fork06.exe > winsup.api/ltp/fork07.exe > winsup.api/ltp/fork11.exe > > Signed-off-by: Igor Podgainoi <[email protected]> > --- > winsup/cygserver/Makefile.am | 2 +- > winsup/cygwin/Makefile.am | 2 +- > winsup/testsuite/Makefile.am | 2 +- > winsup/utils/Makefile.am | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-)
Pushed. We can keep this in, it won't hurt and makes sure we never build Cygwin with HEVA enabled by accident. Thanks, Corinna
