Chris, is that patch small enough to go in without copyright assignment?
On Mon, Mar 12, 2001 at 02:43:03PM -0700, Mark Paulus wrote:
> Enclosed is a patch to fix the 2GB limit problem under Win9x
> exhibited by df. The only problem I can see is a failure with
> repeated calls to a SMB share under WinME. The first call to
> statfs() gets good values, but the 2nd call returns some bogus
> values. I do not have access to a SMB share under Win2K
> to see if it fails there also.
Mark,
I asked this already once you've send your first version. Did you
try your patch with UNC paths? I'm asking because MSDN states
that UNC paths must end with a backslash when using this function
(\\server\share\). It would be really nice if you could have a look.
And two nags:
- Please remove the cvsId patch. We don't use it anywhere in the
sources.
- Could you please rearrange your patch so that it's according
to the GNU coding standard (http://www.gnu.org/prep/standards_toc.html)
For example, not so: func( param ), func(param)
but so: func (param)
and not so: if () {
body
} else {
}
or if ()
{
body
}
else
{
}
but so: if ()
{
body
}
else
{
}
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:[EMAIL PROTECTED]
Red Hat, Inc.
