On 07/07/2009 10:17, Dave Korn wrote: > When we discussed folding features from my previously forked cygport into > upstream back in January, the need to do so was pretty much pre-empted when > Chuck released the gcc-tools packages, but there was one aspect of it that got > dropped on the floor. GCC uses a forked libtool, and because of > default_excludes, my local patches to it get lost every time I run the > packaging step and I keep on having to manually re-add them. The simplest > solution is to just add gcc to the list of packages for which we don't add > ltmain.sh (et al.) to the default_excludes. > > * bin/cygport.in (__pkg_diff): Don't set default_excludes for > GCC[34]*.
Thanks; patch committed to trunk r7222, without the asterisk. (Are you planning to have separate *source* package names for 4.3, 4.4, 4.5, etc.?) BTW, I have been moving away from using .src.patch files, as they are difficult to work with over time. Instead, after using cygport mkpatch to create a .src.patch, I split it up into related chunks if possible with unique names (e.g. VERSION-short-description.patch), move these to the same directory as the .cygport, and add their basename(s) to PATCH_URI. IMO the advantages of this approach are: 1) it's easier to see what the patch does; 2) you don't have to rename (or svn mv or equiv.) the patch with each version/release if it still applies (which it often does); 3) if one patch does not apply in a future version (or has already been applied upstream), others still might apply; 4) they are easier to submit upstream as they are divided up by purpose; 5) patches that are candidates for upstream submission can be separate from those which are not. OTOH .src.patch support isn't going anywhere in the foreseeable future, so hopefully you're set now. Let me know if there is anything else I can do to help. Yaakov Cygwin Ports ------------------------------------------------------------------------------ _______________________________________________ Cygwin-ports-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cygwin-ports-general
