Now that is what I like to see: on a guy's first post to the list he sends two bug reports and two patches. Outstanding!
I've applied both patches (with formatting fixes) and I'll release a new server binary shortly. I also added a patch for the, "press both shifts, release both shifts, input remains shifted" bug. > Side note - I had to comment out the Beep() call in winkeydb.c as this was > causing X to hang. You must be looking at some old source... the function has been changed to MessageBeep. The comments have also been updated to indicate that Beep is a really bad idea. Thanks for the patches, Harold P.S. Regarding the three button emulation patch, I can only say, how embarrassing. I can't believe I have not caught that one on my own. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Stuart Adamson > Sent: Friday, June 07, 2002 5:33 AM > To: '[EMAIL PROTECTED]' > Subject: A couple of patches > > > Attached are a couple of patches. These fix a few bugs that were annoying > me in XFree86 4.2.0. > I can't get access to CVS at the moment so this might be fixed in > there - if > so then feel > free to ignore them ;) > > 1) Key strokes when X loses / gains focus. winkeydb.c now tracks > which keys > are up and down > and releases all down keys when focus is lost. Also, it kills phantom > key up messages > being received (typcially when ALT-TAB'ing to the X server). This was > causing (a) ICE to > switch between windows and (b) bash to see a tab and try to > auto-complete > causing cygwin to > thrash my hard disk looking for all executables in my path ;( > > > 2) emulate3buttons didn't work correctly in single screen mode as > InitOutput > set the timeout to > TRUE (1) rather than the default (50) or user supplied value. > This made > getting the middle > button a matter of good timing ;) > > Side note - I had to comment out the Beep() call in winkeydb.c as this was > causing X to hang. The comments just above the call about the arguments > being ignored are not true - under > Win NT / 2000 the arguments are used (according to MSDN at least ;)). > > > Regards > > > Stuart > >
