Andreas, > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Andreas Schessner > Sent: Thursday, February 13, 2003 8:47 AM > To: alain perrier; Harold L Hunt II; [EMAIL PROTECTED] > Subject: Re: altGR key problem with windows XP > > > Hello Alain and Harold, > > sorry, I had a lot of work last month's and today I just returned out > from vacation. > > Harold L Hunt II wrote: > > >Alain, > > > >The problem with Andreas Schessner's patch was that it modified > functions > >that were not being compiled in the default build. I asked him where the > >missing parts of the patch were, but he never responded. I don't know > if he > >just gave up or if he realized that his patch maybe didn't have > the effect > >that he thought it did. In any case, we no longer have a valid report of > >that problem... if you can contact Andreas Schessner and ask him for the > >rest of his patch, then perhaps we can get somewhere. Until then, I can > >only assume that he made some sort of mistake and decided to keep quiet > >about it :) Seriously, what else can I think when someone stops helping > >to get their patch committed? > > > >Harold > > Harold, that's not true. > I sent you all the modified sources and the patch worked fine for me and > some of my friends. >
The message I sent was: http://cygwin.com/ml/cygwin-xfree/2002-11/msg00137.html Granted, looking back at that message I obviously joined two sentences together and dropped out a few words so it is pretty confusing. What I was trying to say was that the patch you sent me modified a function that was not being compiled in the default compile. It is as simple as that. There are one of two explanations for how this happened: 1) You updated an old or odd version of the source code that only had one version of the function that was not being compiled. When you made a diff it looked like you were updating the version that was #if def'd out, when in fact you were updating a file that only had one version of the function and your file had no such #if def's in it. 2) You modified other files, most likely win.h, and flipped some flags that told that #if def'd out version of the function to be compiled. Either way, I spent two hours back in November trying to get your patch to apply cleanly. I eventually gave up and sent you the above message, to which I never noticed a response (doesn't mean that there was not a response). >From your new explanation I believe that your patch certainly works, but I still need you to download the latest code from CVS and apply your patch to that code by hand. Then run the following: cd xc/programs/Xserver/hw cvs -z3 diff -U3 xwin > xwin-altgr.diff Then send me altgr.diff. That way I will be sure to have any and all files that were updated. Oh yeah, and please follow the style that is used in the current files, as I really don't want to spend time reformatting and renaming variables, etc. Also, try to make only the changes that are necessary. Thanks for your contribution, Harold
