Chris Abbey wrote:
> > if (strlen(foo) == 0)
>
> It's habit forming to do it the otherway, I'll make a mental
> note to use the dangerous form for cygwin patches.
Personally I like if (!strlen (foo)) much more.
I have applied your patch but I have changed this and that:
- You have used `passed_home_path' uninitialized which resulted in
garbage in the output on my system when the `-p' option wasn't
given.
- We are following the GNU coding convention in that a space should be
placed between a function name and the following paren and that the
braces should be placed
if ()
{
cmds;
}
instead of
if () {
cmds;
}
- I have changed the `if (strlen (foo) == 0) conditionals to
`if (foo[0] == '\0')' which I personally prefer when checking
for len == 0.
While incorporating your patch I found a typo in the longopts
structure. I had once written "loca-group" instead of "local-group".
I have fixed this in the same go.
Thanks for contributing that patch,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:[EMAIL PROTECTED]
Red Hat, Inc.
mailto:[EMAIL PROTECTED]
--
Want to unsubscribe from this list?
Send a message to [EMAIL PROTECTED]
