On 2/9/10 8:14 PM, Henrique de Moraes Holschuh wrote:
On Sat, 09 Jan 2010, Bron Gondwana wrote:
On Fri, 08 Jan 2010 15:06 -0500, "Ken Murchison"<[email protected]> wrote:
Can we get some opinions on the feature request below:
https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=3184
I'm pretty much convinced that such a feature is worth adding, the only
question is where should it be configured: imapd.conf or cyrus.conf ?
I'd like to chime in with an "imapd.conf please" - it supports per-service
alterations
if you want, but allows for a sane default and global configuration easily.
The most important thing is the default value, which is what most sites are
going to
be running, so let's make sure we choose a sane default!
IMO, the sane default is to leave it alone by default (i.e. don't do the
setsockopt() call when DSCP is not explicitly configured).
Messing with the DSCP field can have surprising results when the packet
crosses the AS border. You can get far worse service than you would with
best-effort...
The code as it stands doesn't do anything unless the option is present
in the .conf file (which my patch doesn't touch, of course).
-Philip
