Hello,

on Greg's second comments:
commit "*/Makefile.in: add top_(builddir,srcdir) to CPPFLAGS"

+CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib -I$(top_builddir)
-I$(top_builddir)/lib @COM_ERR_CPPFLAGS@ @CPPFLAGS@ @SASLFLAGS@

Surely the correct order is

-I$(top_builddir)
-I$(top_srcdir)
-I$(top_builddir)/lib
-I$(top_srcdir)/lib

I fixed AM_CPPFLAGS to use this order.

perl/annotator/Makefile.PL
+    INSTALLDIRS => 'vendor',

Please don't do that!  I just had to do a whole bunch of futzing to
avoid it :(
This is fixed now.

commit "rename $service_path to $servicedir"


+AC_DEFINE_UNQUOTED(SERVICE_PATH,"$servicedir",[Directory to use for
service binaries])

Don't you want to rename SERVICE_PATH too?
I renamed it.

 commit "remove cyrus_prefix from every Makefile.in, as it is unused"

Since three days ago, it is used, in the perl/ directories to expand
$PERL_PREINSTALL.  Otherwise, looks good.

As a matter of fact, I have removed cyrus_prefix from the Makefile.in-s, but forgot to remove it from configure.in, so PERL_PREINSTALL shall work.

Greetings
  Dilian

Reply via email to