Bron, Thank you very much! That fixed my "reconstruct" problems.
Thank you thank you thank you! -nic On 07/27/2018 01:24 AM, Bron Gondwana wrote:
Hi Nic,Damn! That interface is really frustrating in terms of inability to debug. One possible culprit in all this is b56e391c9579b3c4c9fd6e64fa29e627ec358339. I've just copied that back to 3.0 asc665af571dc1f9d870d53f2aa4ea29bb5cd52738 . Are you able to try with that added?Cheers, Bron. On Fri, Jul 27, 2018, at 06:02, Nic Bernstein wrote:Bron,Answering my own question, I now see that the fix you refer to is in cfb3054, imap/mailbox.c on 1/2/2017, which is in both master and 3.0... However, I've still got the problem, so same failed assertion, but different bug?-nic On 07/24/2018 12:10 PM, Nic Bernstein wrote:Bron, et al.,Was this change ever cherry-picked to 3.0? I am seeing the same issue with recent 3.0 HEAD, but slightly different location:user.masked: updating sync_crc 521983118 => 503807715 fatal error: Internal error: assertion failed: imap/message.c: 4286: !message_need(m, M_RECORD)A git log of imap/message.c doesn't show a commit from 1/2/2017, and nothing affecting imap/message.c around that time seems to line up with this.Please advise, -nic On 01/02/2017 07:13 AM, Bron Gondwana via Cyrus-devel wrote:Thanks for the data. It was 8 bytes of zeros across a UID and INTERNALDATE in the cyrus.index file.I now have a fixed reconstruct which can detect and repair this rather than aborting, pushed to master. I also have a Cassandane testcase for this and a couple of other things that reconstruct does :)Bron. On Thu, 29 Dec 2016, at 09:45, Bron Gondwana via Cyrus-devel wrote:Wow, interesting. Are you willing to send me a tarball containing the spool folder including cyrus.index and cyrus.cache files as well as the email files themselves? I'll need your imapd.conf file as well :)Cheers, Bron. On Thu, 29 Dec 2016, at 00:28, Thomas Cataldo via Cyrus-devel wrote:Hi,Running a build of 3.0.0-beta6 I hit the following assertion on one of my test mailboxes after playing a bit with the replication stuff :root@bm1604:~# /usr/lib/cyrus/sbin/sync_client -n eclipse -o -u t...@ex2016.vmw <mailto:t...@ex2016.vmw>Fatal error: Internal error: assertion failed: imap/message.c: 4246: !message_need(m, M_RECORD)root@bm1604:~# cyradm -u admin0 localhost Password: localhost> version name : Cyrus IMAPD version : 3.0.0-beta6-3-gf721e5b vendor : Project Cyrus support-url: http://www.cyrusimap.org os : Linux os-version : 4.4.0-57-generic environment: Built w/Cyrus SASL 2.1.26 Running w/Cyrus SASL 2.1.26 Built w/OpenSSL 1.0.2g 1 Mar 2016 Running w/OpenSSL 1.0.2g 1 Mar 2016 Built w/zlib 1.2.8 Running w/zlib 1.2.8 CMU Sieve 2.4 mmap = shared lock = fcntl nonblock = ioctl idle = idled root@bm1604:~# telnet localhost 1143 Connected to localhost. Escape character is '^]'.* OK [CAPABILITY IMAP4rev1 LITERAL+ ID ENABLE STARTTLS AUTH=PLAIN SASL-IR] server ready. login t...@ex2016.vmw <mailto:t...@ex2016.vmw> xxxxxx. OK [CAPABILITY IMAP4rev1 LITERAL+ ID ENABLE ACL RIGHTS=kxten QUOTA MAILBOX-REFERRALS NAMESPACE UIDPLUS NO_ATOMIC_RENAME UNSELECT CHILDREN MULTIAPPEND BINARY CATENATE CONDSTORE ESEARCH SEARCH=FUZZY SORT SORT=MODSEQ SORT=DISPLAY SORT=UID THREAD=ORDEREDSUBJECT THREAD=REFERENCES THREAD=REFS ANNOTATEMORE ANNOTATE-EXPERIMENT-1 METADATA LIST-EXTENDED LIST-STATUS LIST-MYRIGHTS LIST-METADATA WITHIN QRESYNC SCAN XLIST XMOVE MOVE SPECIAL-USE CREATE-SPECIAL-USE DIGEST=SHA1 X-REPLICATION URLAUTH URLAUTH=BINARY LOGINDISABLED COMPRESS=DEFLATE X-QUOTA=STORAGE X-QUOTA=MESSAGE X-QUOTA=X-ANNOTATION-STORAGE X-QUOTA=X-NUM-FOLDERS IDLE] User logged in SESSIONID=<cyrus-43098-1482931179-1-18150325414286070410>. select inbox* BYE Fatal error: Internal error: assertion failed: imap/message.c: 4246: !message_need(m, M_RECORD)Connection closed by foreign host. Trying to reconstruct the mailbox does not help :root@bm1604:~# /usr/lib/cyrus/sbin/reconstruct -rfxGROU t...@ex2016.vmw <mailto:t...@ex2016.vmw>t...@ex2016.vmw <mailto:t...@ex2016.vmw> The error is still here after that. Any idea ? Regards, Thomas.-- Bron Gondwana br...@fastmail.fm <mailto:br...@fastmail.fm>-- Bron Gondwana br...@fastmail.fm <mailto:br...@fastmail.fm>-- Nic bernstein...@onlight.com <mailto:n...@onlight.com> Onlight, Inc.www.onlight.com <http://www.onlight.com> 6525 W Bluemound Road, Suite 24 v. 414.272.4477 Milwaukee, Wisconsin 53213-4073-- Nic bernstein...@onlight.com <mailto:n...@onlight.com> Onlight, Inc.www.onlight.com <http://www.onlight.com> 6525 W Bluemound Road, Suite 24 v. 414.272.4477 Milwaukee, Wisconsin 53213-4073-- Bron Gondwana, CEO, FastMail Pty Ltd br...@fastmailteam.com
-- Nic Bernstein n...@onlight.com Onlight, Inc. www.onlight.com 6525 W Bluemound Road, Suite 24 v. 414.272.4477 Milwaukee, Wisconsin 53213-4073
<<attachment: nic.vcf>>
