On Apr 7, 2008, at 2:25 AM, Stefan Behnel wrote: > Hi Robert, > > thanks for this release. A few comments: > > The file "MANIFEST" shouldn't be in the repository as it's > autogenerated from > the file "MANIFEST.in" by distutils.
Yep. Realized that after the fact. It's not in the directory any more. > Also, there seems to be a problem with cimporting public extension > classes > from another Cython module. I was away last week, so I couldn't > test with the > release candidate, but building lxml now gives me: And this is exactly what I was hoping to avoid with an rc...bad timing I guess. Anyways, I've fixed this now and released 0.9.6.13.1. > > ----------------- > Traceback (most recent call last): > File "setup.py", line 106, in <module> > **extra_options > File "distutils/core.py", line 151, in setup > File "distutils/dist.py", line 974, in run_commands > File "distutils/dist.py", line 994, in run_command > File "distutils/command/build_ext.py", line 290, in run > File "/.../Cython/Distutils/build_ext.py", line 81, in > build_extensions > ext.sources = self.cython_sources(ext.sources, ext) > File "/.../Cython/Distutils/build_ext.py", line 193, in > cython_sources > full_module_name=module_name) > File "/.../Cython/Compiler/Main.py", line 304, in compile > return context.compile(source, options, full_module_name) > File "/.../Cython/Compiler/Main.py", line 201, in compile > tree.process_implementation(scope, options, result) > File "/.../Cython/Compiler/ModuleNode.py", line 78, in > process_implementation > self.generate_c_code(env, options, result) > File "/.../Cython/Compiler/ModuleNode.py", line 262, in > generate_c_code > self.generate_declarations_for_modules(env, modules, code.h) > File "/.../Cython/Compiler/ModuleNode.py", line 454, in > generate_declarations_for_modules > vtabslot_list = self.generate_vtabslot_list(vtabslot_dict) > File "/.../Cython/Compiler/ModuleNode.py", line 418, in > generate_vtabslot_list > if(recurse_vtabslot_check_inheritance(vtab_list[j],vtab_list[i], > vtab_dict)==1): > File "/.../Cython/Compiler/ModuleNode.py", line 44, in > recurse_vtabslot_check_inheritance > base = dict[base.type.base_type.objstruct_cname] > KeyError: 'LxmlElementBase' > ----------------- > > This class is cimported from this definition in a .pxd: > > cdef extern from "lxml.etree_api.h": > cdef class lxml.etree.ElementBase(_Element) \ > [ object LxmlElementBase ]: > ... > > http://codespeak.net/svn/lxml/trunk/src/lxml/etreepublic.pxd > > by this Cython file: > > http://codespeak.net/svn/lxml/trunk/src/lxml/lxml.objectify.pyx > > > I don't think there is a test case for cimporting extension classes > yet. > > I'll have to see when I find the time to look into this, but maybe > not before > the end of the week. > > Stefan _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
