Re: [Cython] Some small phase refactorings

Dag Sverre Seljebotn Tue, 06 May 2008 23:46:45 -0700

Dag Sverre Seljebotn wrote:

I think one could put a generic accept function in the Node class  
that would dispatch based on class name (or some class attribute) if  
one wanted, rather than having to write it for every class.

Yes, simply move the function. You spoke against using the class name in 
the other thread though. I suppose I could use an attribute; still I 
like decorators much better.

Sorry, left the thread of thought too early (I seem to do this a lot, will try to read once more through my outgoing mails).

I meant: Yes, simply move part of the function that is in VisitorTransform in the patch into Node instead, and call it from VisitorTransform. It is almost a cut and paste, so of course it is doable :-)

-- 
Dag Sverre

_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Re: [Cython] Some small phase refactorings

Reply via email to