On May 8, 2008, at 11:12 AM, Lisandro Dalcin wrote: > On 5/8/08, Robert Bradshaw <[EMAIL PROTECTED]> wrote: >> Thanks. I briefly glanced at it and it looks good. What you probably >> want to do is commit and then export the patch (that way it will >> have >> some history attached, and you'll get credit for it.) > > OK. But perhaps better... It's really hard for you to clone > cython-devel and name it cython-devel-py3k, and give me commit access > to only that repo?
Sure. I'll just need a htpasswd file so you can authenticate. (This will add you as a user to trac too.) >> One remark I had is that perhaps more care needs to be done with >> "PyInt_CheckExact" as in Py2 this implies that the size fits into a >> long, so it's not quite the same as PyLong_CheckExact. > > Good catch!. I believe there is PyLong_FitsInLong or something similar > to this. I have to check... Perhaps this should be handled at a higher level--i.e. we should see where in the source we're using PyInt_CheckExact, etc. and do something else there so we don't need the #defines... >> IMHO, all sloots should be keept, or >>> all unused in py3k should be removed. >> >> Could you elaborate a bit more on what you mean by "unused?" If >> they're still in the struct, I'd think we would need to keep them so >> it has the right size/layout, right? > > I mean that Python 3.0 sources are maintaining some slots in the > struct for no good reason... for example, nb_hex and nb_oct. IMHO, > they should be removed in core Python... But if they are not removed, > of course we still have to fill the struct. > >> PyClass_New is gone, I've >> >> Filling the dict ahead of time might actually work better... > > Just a question: Why Cython does not implement old-style classes this > way for Python2.X ? Filling a dict with PyCFunction's and next calling > PyClass_New does not work (I've never tried)? No idea, this is how Greg wrote it. > >> >> I actually have no idea on this one--maybe there's some system call >> that can give this information? Stefan would probably know better >> than me. > > Anyway this is not really important at this point. In the worst > scenario, Python would not be able to find a source file for > displaying traceback lines in a fancy way (like the one in IPython), > but this is not a real problem. Having good tracebacks is important to me at least, hopefully we'll find a way to do it. - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
