Well, what I do not like about your patch is that the cdef module globals are not initialized to 'None' in the module init function. And this is a bit unsafe, Cython almost always assumes that PyObect* pointers are not-NULL. I can imagine some code breaking with your patch.
On Wed, Oct 15, 2008 at 2:04 PM, Dag Sverre Seljebotn <[EMAIL PROTECTED]> wrote: > Lisandro Dalcin wrote: >> Dag, I was working on a fix for tiket #90 >> <http://trac.cython.org/cython_trac/ticket/90>, but your latest commit >> forced me to rework my patch. Could you please review the attached >> patch (you also have it in trac!!)? >> >> All the tests pass with this patch, but perhaps I'm missing >> something... Thanks in advance. > > See <http://trac.cython.org/cython_trac/ticket/90> > > """ > The patch should work -- however it seems a bit fragile. > > I'm attaching an alternative version, which rather modifies how the > initalization happens. This should also be very slightly faster. > """ > > I don't dare to apply my patch though, a bit unsure if it could break > something, so somebody please review my patch :-) > > > -- > Dag Sverre > _______________________________________________ > Cython-dev mailing list > [email protected] > http://codespeak.net/mailman/listinfo/cython-dev > -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
