Lisandro wrote: > On Thu, Oct 16, 2008 at 5:00 AM, Dag Sverre Seljebotn > <[EMAIL PROTECTED]> wrote: >> The two should be orthogonal issues. I really believe that my patch is >> how >> the first problem should be solved. Attaching now how I believe the >> second >> problem should be solved, for which there seems to be no patch yet >> anyway. > > I've attached a new patch trying to fix all the issues following your > comments. And you are tight, this patch seems to be far better than my > previous ones. > > http://trac.cython.org/cython_trac/attachment/ticket/90/GLOBALS.diff > > I could add a testcase, but a really good one would need the > 'modulecleanup' directive implemented, as I need to play with the > Py_AtExit() Python C-API call in order to detect that the generated > module cleanup is actually working.
Positive review! (A testcase that could be added is this one: """ cdef object unused """ (that's all!) as that one was pretty nasty, resulting in uncompileable code, and we don't want regression on it if somebody changes what you did in the future...) Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
