Lisandro wrote: > Dag, review this, perhaps I'm missing something. Positive review (assuming the test_numpy.pyx testcase still runs of course; I assume it will, but it is strange that it currently works without a problem, as these are used in __getbuffer__ ...).
BTW obviously all the available functions/macros should be defined in that pxd, I just didn't get around to it. Any patches improving numpy.pxd in this area will be accepted without any discussion (as long as the pointer types are got right). > BTW, Did you notice that the 'return' type of the macro > "PyArray_ITEMSIZE" is not 'Py_ssize_t' but 'int' (at least in > numpy-1.2.0)??. Should this be fixed? Please do. It looks nicer (though it doesn't really matter for non-pointer types, as it is C which is going to do the real typechecking in this case; Cython only needs to know int vs. float and signed vs. unsigned). Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
