Thanks. It looks good now, I've committed it. BTW, if you commit then create a patch with "hg export" it will allow you to make a changelog statement and also make sure you get credit for it :). Also, you can import a patch from an raw email message (in which case it pulls the authorship from the from/subject headers).
- Robert On Oct 27, 2008, at 8:53 AM, Lisandro Dalcin wrote: > new patch attached, following Dag's advice. Now also fixed > set_utility_code() calls for getitem and setitem. > > On Mon, Oct 27, 2008 at 12:16 PM, Stefan Behnel > <[EMAIL PROTECTED]> wrote: >> Could you add some more test cases to make sure this also works with >> negative values and unsigned types? From looking at the code, I'm >> not sure >> if these cases are handled as expected. > > Done, added checks for [unsigned] char/int/longlong with -1,0,1 > values. But the utility codes are still a bit hard to follow ;-) > > > >> >>> I had to add a new utility code, but I could not figure out how to >>> emit that utility code for the particular case of 'del obj[i]', I >>> mean, I do not know how to differentiate a setitem from a delitem. >>> Apart from that, the patch seems to work and all the testsuite pass. >> >> As Dag already wrote, utility code is generated at need (i.e. when >> they >> are used) during code generation. This avoids duplicating the >> necessary >> decision logic in the analysis and output phase. > > Yes, I know that, what I was missing was the > code.globalstate.use_utility_code() trick. Many thanks, Dag. > > > > -- > Lisandro Dalcín > --------------- > Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) > Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) > Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) > PTLC - Güemes 3450, (3000) Santa Fe, Argentina > Tel/Fax: +54-(0) > 342-451.1594<delitem_index.diff>______________________________________ > _________ > Cython-dev mailing list > [email protected] > http://codespeak.net/mailman/listinfo/cython-dev _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
