Stefan Behnel wrote: > Dag Sverre Seljebotn wrote: > >> There's one thing that worries me: Calling TupleNode's allocate_temps. >> [...] >> Ideally, one should find a way of not having to call analyse_types and >> allocate_temps on TupleNode, instead one should pass the different >> variables that is set during analysis directly to the TupleNode >> constructor (i.e. the TupleNode must be constructed in an "analysed >> state"). >> > > That's what I started off with, until I noticed that I was only doing > stuff that analyse_types() and allocate_temps() were doing already. > > Initialising the TupleNode manually leads to tons of stuff that you have > to build/set up first. > > I'll take another look at it. Thanks for the review. > I'd add a static member method "create_analysed" in TupleNode which does all the setup stuff, but which doesn't need an "env" passed in. Then there should be much potential in code reuse in helper methods within TupleNode.
Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
