Lisandro Dalcin wrote:
> Take a look, I believe the fix is valid, in such case please push it.

Looks ok to me. I can't push it now, but I will do it tonight, unless
someone else is faster.


> Today I lost my self-confidence, don't like to mess the codebase again

You're still pretty new as a Cython developer. I've been working on the
code for a few years now, and I'm still learning new things about old code
from time to time.

As long as we keep reviewing code (and as long as the test suite keeps
growing), the harmfulness of these things will stay within bounds.

Stefan

_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to