It mostly looks good to me. To summarize, you basically made a macro that's the function for converting to/from the various types, and applied that everywhere, right?
In your tests, "1..." could catch 100 or anything like that, so I'm not sure if that's a concern. - Robert On Feb 26, 2009, at 3:41 PM, Lisandro Dalcin wrote: > Before going on, I would like to know your opinion... patch and > testcase attached ... > > > -- > Lisandro Dalcín > --------------- > Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) > Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) > Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) > PTLC - Güemes 3450, (3000) Santa Fe, Argentina > Tel/Fax: +54-(0) > 342-451.1594<numerictypes.pyx><NUMERICTYPES.diff>_____________________ > __________________________ > Cython-dev mailing list > [email protected] > http://codespeak.net/mailman/listinfo/cython-dev _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
