Stefan Behnel wrote:
> Hi,
>
> I just pushed the constant allocation refactoring to cython-unstable. There
> are still a few failing test cases, especially regarding struct coercion.
>
> The main problem was that some places in the code expected the result code
> to be available for constants during the analysis phase. Where I could not
> move it to the code generation phase, I had to replace this with a call to
> "compile_time_value()" for now, not sure if this is the right thing to
> do... The change can clearly benefit from some review and some additional
> bug fixing. I hope someone beats me to it. :)
>   
Unfortunately I don't think I'll beat you to it; I just wanted to say 
THANK YOU for doing this! It looks very nice.

(The places where result_code is used during analysis should go anyway; 
after the temp refactoring is complete we'll hopefully remove 
result_code from pre-code-generation entirely.)

Dag Sverre
_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to