On Thu, Mar 19, 2009 at 7:40 AM, Stefan Behnel <[email protected]> wrote: > > Lisandro Dalcin wrote: >> Some time ago, I've posted some mails about thread issues in Python >> 2.3. Unfortunately, those post did not receive any attention. >> > > Just a quick note that I applied your patch. > > http://hg.cython.org/cython-devel/rev/9a1f6f7c260a > http://hg.cython.org/cython-devel/rev/0bd3bfd487a5 >
Ok. It seems the bug is also in some 2.4 releases... Then , two comments: * I would suggest changing the name of the utility code from "py23_init_threads_utility_code" to "force_init_threads_utility_code"... Just to avoid confusion. * When I wrote the patch, I took the precaution of protecting "#ifndef __PYX_FORCE_INIT_THREADS" just in case some users would have the need to decide themselves what to do... If this feature is maintained (I would), then perhaps the macro should have a more "public" name, like "CYTHON_FORCE_INIT_THREADS"... Please note that I'm +0 on this, it is unlikely that users will need tho hack on this... So, I'll leave the final decision on your hands ... -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
