Prajwal Suhas P wrote:
> Can someone review this patch for ticket#203?

Looking at the patch, I noticed that it duplicates a lot of code. Could
you try to limit this to the parts that are really different? This would
make the code a lot easier to read and the patch easier to review.

For example, one section uses "temp_range_bound", where the other spells
"self.bound2.result()". Assigning "self.bound2.result()" to
"temp_range_bound" in the "else" case would make the first code output
identical in both conditional branches, so that it could happen once
outside of the blocks.

Stefan

_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to