On May 12, 2009, at 10:58 AM, Lisandro Dalcin wrote: > On Tue, May 12, 2009 at 12:58 PM, Dag Sverre Seljebotn > <[email protected]> wrote: >> Lisandro Dalcin wrote: >>> I want to raise your attention to ticket #287, as my patch could be >>> controversial. I even changed my mind, and fixed my previous work on >>> all this to prefer 'nb_int' over 'nb_long' in __Pyx_PyNumber_Int(). >>> This change was not a quick hack to get things solved, but rather a >>> hard to take decision after diving core CPython sources from 2.3 to >>> 2.7. IMHO, the 'nb_long' slot should have been deprecated long, long >>> ago in core CPython. I would like this to be discussed a bit more >>> before next release. >> >> I don't think I'm qualified to comment on this. Do you consider it >> safe >> enough yourself for inclusion in Cython 0.11.2, or is it blocked >> pending >> review by Stefan or Robert? >> > > IMHO, it is ready for 0.11.2, but I would like to know other opinions, > just in case... As I said, the patch could be controversial, specially > the change for Py2 in Pyx_PyNumber_Int(), where the "nb_int" slot is > preferred over "nb_long" slot. > > If Robert/Stefan does not comment on this on a couple of days (and > provide an example showing the brokenness of my approach ;-) ), I > would just push the patch.
Sorry, most of my "dev" time has been focused on the immanent Sage 4.0 release, which is why I haven't had time to comment on many of the things that have shown up here. - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
