Dag Sverre Seljebotn wrote: > Robert Bradshaw wrote: >> On May 14, 2009, at 11:22 AM, Dag Sverre Seljebotn wrote: >> >>> Robert Bradshaw wrote: >>>> Oops. Yes. >>> While you're at it, could you review this one as well? Slightly unsure >>> about it. >>> >>> http://hg.cython.org/cython-devel/rev/f0d9b51d7ec8 >> I was trying to avoid calling create_*_utility_code many times, >> because it may be slowish. > > Sure, and the bug stumped me for quite a while. If you can do it without > modifying PyrexType objects (e.g. store the state in env instead) then > feel free. > > If we only were in code generation land, you could simply do > > if not token in code.globalstate.utility_codes: ...
Whoops, sorry, commented on the wrong changeset!! OK, I see, that is not where the problem was, I can readd the attribute checks. (The problem was create*utility_code always returning True, thus making the if impossible to enter.) Thanks! -- Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
