On Jun 19, 2009, at 9:44 AM, Lisandro Dalcin wrote:
> I've finally managed to write a more or less working patch... Look at
> the test, I've tried to cover many corner cases...
>
> 1) Dag & Kurt: I bet you will be happy.
>
>
> 2) Robert: your eyeballs needed, please comment on this:
>
> a) Look at the changes outside PyrexTypes.pyx, I believe they make
> sense, though I would like you to confirm that.
>
> b) In the past, you raised some concerns about __int32 from ILP64
> model... A possible (and suboptimal, no overflow-safe) way of handling
> that is there, though "#if 0" disabled. I've tried to take advantage
> of "_PyLong_{As/From}ByteArray()", but that (in particular, the "As"
> one) is somewhat harder to use, as we should pass a PyLongObject type.
Sorry I've taken so long to get back on this. I have read all the
code, and it looks good. I've posted some comments on trac. http://
trac.cython.org/cython_trac/ticket/333
- Robert
_______________________________________________
Cython-dev mailing list
Cython-dev@codespeak.net
http://codespeak.net/mailman/listinfo/cython-dev
