On Mon, Jan 4, 2010 at 2:43 PM, Hoyt Koepke <[email protected]> wrote: > I'd like to announce a new open source python/cython package, > TreeDict, that the cython community might be interested in. I've been > using it and testing it for a number of months and have finally > documented it sufficiently to release. This is my first real open > source software package that I hope can be generally useful, > particularly to the scientific community, and I'd greatly appreciate > feedback on any and all parts of the > design/coding/project/release/documentation from the more experienced > developers here.
Neat! From a quick read of the docs, I have a few minor questions: -- Why invent a new mechanism for global variables (getTree/treeExists)? It seems redundant (and violates "there's only one way to do it", if you care about that prescription for pythonicity ;-) -- I'd prefer PEP8-complaint method names, e.g. branch_name rather than branchName. -- What advantage do you get from using cython instead of regular python? I guess the edit distance calculation for similarity matching is CPU-bound, but I wouldn't expect even that to be a bottleneck in regular usage. -- Nathaniel _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
