On 11 April 2010 14:00, Stefan Behnel <[email protected]> wrote: > Lisandro Dalcin, 10.04.2010 00:11: >> Is this patch fine? > > I think the reason why no-one replied so far is that this kind of patch is > basically impossible to validate on eye-sight. The changes in > "modifiers_and_name_to_type" seem to be mostly whitespace noise - it would > be easier to read the patch without that. >
Well, these changes are really uninteresting. > > > I mean, look at the new testcase in pure.pyx... >> Should we support all basic C types in cython.declare()? > > Certainly all C types that can be mapped to a Python type in some way (i.e. > those that make sense in pure more). > Sorry, could you clarify? Are you fine what the code I've added in tests/run/pure.pyx ? > >> BTW, I would really like to remove that "modifiers_and_name_to_type" >> dictionary > > How would you do that? > Still not sure, but we have to large dicts in PyrexTypes, that smells to unnecessary duplication. -- Lisandro Dalcin --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
